Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create fp from json #207

Merged
merged 6 commits into from
Dec 10, 2024
Merged

chore: create fp from json #207

merged 6 commits into from
Dec 10, 2024

Conversation

Lazar955
Copy link
Member

@Lazar955 Lazar955 commented Dec 9, 2024

Alternative to passing in flags, the operator would provide a JSON file.

Closes

@Lazar955 Lazar955 requested a review from gitferry December 9, 2024 14:28
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A minor comment. @samricotta Let's modify the instructions accordingly after it is merged

chainID string
eotsPK string
passphrase string
daemonAddress string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this should be part of it. Can we make it a flag either way?

@gitferry gitferry requested a review from samricotta December 10, 2024 07:36
@Lazar955 Lazar955 merged commit 768bec3 into main Dec 10, 2024
12 checks passed
@Lazar955 Lazar955 deleted the lazar/create-fp-json branch December 10, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants